fidl_fuchsia_net_routes_ext/

lib.rs

// Copyright 2023 The Fuchsia Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

//! Extensions for the fuchsia.net.routes FIDL library.
//!
//! The fuchsia.net.routes API has separate V4 and V6 watcher variants to
//! enforce maximum type safety and access control at the API layer. For the
//! most part, these APIs are a mirror image of one another. This library
//! provides an a single implementation that is generic over
//! [`net_types::ip::Ip`] version, as well as conversion utilities.

#![deny(missing_docs)]

pub mod admin;
pub mod rules;
pub mod testutil;

use std::collections::HashSet;
use std::fmt::{Debug, Display};

use async_utils::{fold, stream};
use fidl_fuchsia_net as fnet;
use fidl_fuchsia_net_ext::{self as fnet_ext, IntoExt as _, TryIntoExt as _};
use fidl_fuchsia_net_routes as fnet_routes;
use fidl_fuchsia_net_routes_admin as fnet_routes_admin;
use fidl_fuchsia_net_stack as fnet_stack;
use futures::{Future, Stream, TryStreamExt as _};
use net_types::ip::{GenericOverIp, Ip, Ipv4, Ipv6, Ipv6Addr, Subnet};
use net_types::{SpecifiedAddr, UnicastAddress, Witness as _};
use thiserror::Error;

/// Conversion errors from `fnet_routes` FIDL types to the generic equivalents
/// defined in this module.
#[derive(Clone, Copy, Debug, Error, PartialEq)]
pub enum FidlConversionError<UnsetFieldSpecifier: Debug + Display> {
    /// A required field was unset. The provided string is the human-readable
    /// name of the unset field.
    #[error("required field is unset: {0}")]
    RequiredFieldUnset(UnsetFieldSpecifier),
    /// Destination Subnet conversion failed.
    #[error("failed to convert `destination` to net_types subnet: {0:?}")]
    DestinationSubnet(net_types::ip::SubnetError),
    /// Next-Hop specified address conversion failed.
    #[error("failed to convert `next_hop` to a specified addr")]
    UnspecifiedNextHop,
    /// Next-Hop unicast address conversion failed.
    #[error("failed to convert `next_hop` to a unicast addr")]
    NextHopNotUnicast,
}

impl<T: Debug + Display> FidlConversionError<T> {
    fn map_unset_fields<U: Debug + Display>(
        self,
        f: impl FnOnce(T) -> U,
    ) -> FidlConversionError<U> {
        match self {
            FidlConversionError::RequiredFieldUnset(field) => {
                FidlConversionError::RequiredFieldUnset(f(field))
            }
            FidlConversionError::DestinationSubnet(err) => {
                FidlConversionError::DestinationSubnet(err)
            }
            FidlConversionError::UnspecifiedNextHop => FidlConversionError::UnspecifiedNextHop,
            FidlConversionError::NextHopNotUnicast => FidlConversionError::NextHopNotUnicast,
        }
    }
}

impl From<FidlConversionError<RoutePropertiesRequiredFields>> for fnet_routes_admin::RouteSetError {
    fn from(error: FidlConversionError<RoutePropertiesRequiredFields>) -> Self {
        match error {
            FidlConversionError::RequiredFieldUnset(field_name) => match field_name {
                RoutePropertiesRequiredFields::SpecifiedProperties => {
                    fnet_routes_admin::RouteSetError::MissingRouteProperties
                }
                RoutePropertiesRequiredFields::WithinSpecifiedProperties(field_name) => {
                    match field_name {
                        SpecifiedRoutePropertiesRequiredFields::Metric => {
                            fnet_routes_admin::RouteSetError::MissingMetric
                        }
                    }
                }
            },
            FidlConversionError::DestinationSubnet(_subnet_error) => {
                fnet_routes_admin::RouteSetError::InvalidDestinationSubnet
            }
            FidlConversionError::UnspecifiedNextHop | FidlConversionError::NextHopNotUnicast => {
                fnet_routes_admin::RouteSetError::InvalidNextHop
            }
        }
    }
}

/// Conversion errors from generic route types defined in this module to their
/// FIDL equivalents.
#[derive(Clone, Copy, Debug, Error, PartialEq)]
pub enum NetTypeConversionError {
    /// A union type was `Unknown`.
    #[error("Union type is of the `Unknown` variant: {0}")]
    UnknownUnionVariant(&'static str),
}

/// The specified properties of a route. This type enforces that all required
/// fields from [`fnet_routes::SpecifiedRouteProperties`] are set.
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
pub struct SpecifiedRouteProperties {
    /// The specified metric of the route.
    pub metric: fnet_routes::SpecifiedMetric,
}

/// Required fields in [`SpecifiedRouteProperties`].
#[derive(Error, Debug, Clone, PartialEq, Eq)]
#[allow(missing_docs)]
pub enum SpecifiedRoutePropertiesRequiredFields {
    #[error("fuchsia.net.routes/SpecifiedRouteProperties.metric")]
    Metric,
}

impl TryFrom<fnet_routes::SpecifiedRouteProperties> for SpecifiedRouteProperties {
    type Error = FidlConversionError<SpecifiedRoutePropertiesRequiredFields>;
    fn try_from(
        specified_properties: fnet_routes::SpecifiedRouteProperties,
    ) -> Result<Self, Self::Error> {
        Ok(SpecifiedRouteProperties {
            metric: specified_properties.metric.ok_or(FidlConversionError::RequiredFieldUnset(
                SpecifiedRoutePropertiesRequiredFields::Metric,
            ))?,
        })
    }
}

impl From<SpecifiedRouteProperties> for fnet_routes::SpecifiedRouteProperties {
    fn from(
        specified_properties: SpecifiedRouteProperties,
    ) -> fnet_routes::SpecifiedRouteProperties {
        let SpecifiedRouteProperties { metric } = specified_properties;
        fnet_routes::SpecifiedRouteProperties { metric: Some(metric), ..Default::default() }
    }
}

/// The effective properties of a route. This type enforces that all required
/// fields from [`fnet_routes::EffectiveRouteProperties`] are set.
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
pub struct EffectiveRouteProperties {
    /// The effective metric of the route.
    pub metric: u32,
}

#[derive(Debug, Error, Clone, PartialEq, Eq)]
#[allow(missing_docs)]
pub enum EffectiveRoutePropertiesRequiredFields {
    #[error("fuchsia.net.routes/EffectiveRouteProperties.metric")]
    Metric,
}

impl TryFrom<fnet_routes::EffectiveRouteProperties> for EffectiveRouteProperties {
    type Error = FidlConversionError<EffectiveRoutePropertiesRequiredFields>;
    fn try_from(
        effective_properties: fnet_routes::EffectiveRouteProperties,
    ) -> Result<Self, Self::Error> {
        Ok(EffectiveRouteProperties {
            metric: effective_properties.metric.ok_or(FidlConversionError::RequiredFieldUnset(
                EffectiveRoutePropertiesRequiredFields::Metric,
            ))?,
        })
    }
}

impl From<EffectiveRouteProperties> for fnet_routes::EffectiveRouteProperties {
    fn from(
        effective_properties: EffectiveRouteProperties,
    ) -> fnet_routes::EffectiveRouteProperties {
        let EffectiveRouteProperties { metric } = effective_properties;
        fnet_routes::EffectiveRouteProperties { metric: Some(metric), ..Default::default() }
    }
}

/// The properties of a route, abstracting over
/// [`fnet_routes::RoutePropertiesV4`] and [`fnet_routes::RoutePropertiesV6`].
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
pub struct RouteProperties {
    /// the specified properties of the route.
    pub specified_properties: SpecifiedRouteProperties,
}

impl RouteProperties {
    /// Constructs a [`RouteProperties`] from a specified metric.
    pub fn from_explicit_metric(metric: u32) -> Self {
        Self {
            specified_properties: SpecifiedRouteProperties {
                metric: fnet_routes::SpecifiedMetric::ExplicitMetric(metric),
            },
        }
    }
}

#[derive(Debug, Error, Clone, PartialEq, Eq)]
#[allow(missing_docs)]
pub enum RoutePropertiesRequiredFields {
    #[error("fuchsia.net.routes/RoutePropertiesV#.specified_properties")]
    SpecifiedProperties,
    #[error(transparent)]
    WithinSpecifiedProperties(#[from] SpecifiedRoutePropertiesRequiredFields),
}

impl TryFrom<fnet_routes::RoutePropertiesV4> for RouteProperties {
    type Error = FidlConversionError<RoutePropertiesRequiredFields>;
    fn try_from(properties: fnet_routes::RoutePropertiesV4) -> Result<Self, Self::Error> {
        Ok(RouteProperties {
            specified_properties: properties
                .specified_properties
                .ok_or(FidlConversionError::RequiredFieldUnset(
                    RoutePropertiesRequiredFields::SpecifiedProperties,
                ))?
                .try_into()
                .map_err(|e: FidlConversionError<_>| {
                    e.map_unset_fields(RoutePropertiesRequiredFields::WithinSpecifiedProperties)
                })?,
        })
    }
}

impl TryFrom<fnet_routes::RoutePropertiesV6> for RouteProperties {
    type Error = FidlConversionError<RoutePropertiesRequiredFields>;
    fn try_from(properties: fnet_routes::RoutePropertiesV6) -> Result<Self, Self::Error> {
        Ok(RouteProperties {
            specified_properties: properties
                .specified_properties
                .ok_or(FidlConversionError::RequiredFieldUnset(
                    RoutePropertiesRequiredFields::SpecifiedProperties,
                ))?
                .try_into()
                .map_err(|e: FidlConversionError<_>| {
                    e.map_unset_fields(RoutePropertiesRequiredFields::WithinSpecifiedProperties)
                })?,
        })
    }
}

impl From<RouteProperties> for fnet_routes::RoutePropertiesV4 {
    fn from(properties: RouteProperties) -> fnet_routes::RoutePropertiesV4 {
        let RouteProperties { specified_properties } = properties;
        fnet_routes::RoutePropertiesV4 {
            specified_properties: Some(specified_properties.into()),
            ..Default::default()
        }
    }
}

impl From<RouteProperties> for fnet_routes::RoutePropertiesV6 {
    fn from(properties: RouteProperties) -> fnet_routes::RoutePropertiesV6 {
        let RouteProperties { specified_properties } = properties;
        fnet_routes::RoutePropertiesV6 {
            specified_properties: Some(specified_properties.into()),
            ..Default::default()
        }
    }
}

/// A target of a route, abstracting over [`fnet_routes::RouteTargetV4`] and
/// [`fnet_routes::RouteTargetV6`].
///
/// The `next_hop` address is required to be unicast. IPv4 addresses can only be
/// determined to be unicast within the broader context of a subnet, hence they
/// are only guaranteed to be specified in this context. IPv6 addresses,
/// however, will be confirmed to be unicast.
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
pub struct RouteTarget<I: Ip> {
    /// The outbound_interface to use when forwarding packets.
    pub outbound_interface: u64,
    /// The next-hop IP address of the route.
    pub next_hop: Option<SpecifiedAddr<I::Addr>>,
}

impl TryFrom<fnet_routes::RouteTargetV4> for RouteTarget<Ipv4> {
    type Error = FidlConversionError<NeverMissingFields>;
    fn try_from(target: fnet_routes::RouteTargetV4) -> Result<Self, Self::Error> {
        let fnet_routes::RouteTargetV4 { outbound_interface, next_hop } = target;
        let next_hop: Option<SpecifiedAddr<net_types::ip::Ipv4Addr>> = next_hop
            .map(|addr| {
                SpecifiedAddr::new((*addr).into_ext())
                    .ok_or(FidlConversionError::UnspecifiedNextHop)
            })
            .transpose()?;
        if let Some(next_hop) = next_hop {
            if next_hop.is_limited_broadcast() {
                return Err(FidlConversionError::NextHopNotUnicast);
            }
        }
        Ok(RouteTarget { outbound_interface, next_hop })
    }
}

impl TryFrom<fnet_routes::RouteTargetV6> for RouteTarget<Ipv6> {
    type Error = FidlConversionError<NeverMissingFields>;
    fn try_from(target: fnet_routes::RouteTargetV6) -> Result<Self, Self::Error> {
        let fnet_routes::RouteTargetV6 { outbound_interface, next_hop } = target;
        let addr: Option<SpecifiedAddr<Ipv6Addr>> = next_hop
            .map(|addr| {
                SpecifiedAddr::new((*addr).into_ext())
                    .ok_or(FidlConversionError::UnspecifiedNextHop)
            })
            .transpose()?;
        if let Some(specified_addr) = addr {
            if !specified_addr.is_unicast() {
                return Err(FidlConversionError::NextHopNotUnicast);
            }
        }
        Ok(RouteTarget { outbound_interface, next_hop: addr })
    }
}

impl From<RouteTarget<Ipv4>> for fnet_routes::RouteTargetV4 {
    fn from(target: RouteTarget<Ipv4>) -> fnet_routes::RouteTargetV4 {
        let RouteTarget { outbound_interface, next_hop } = target;
        fnet_routes::RouteTargetV4 {
            outbound_interface: outbound_interface,
            next_hop: next_hop.map(|addr| Box::new((*addr).into_ext())),
        }
    }
}

impl From<RouteTarget<Ipv6>> for fnet_routes::RouteTargetV6 {
    fn from(target: RouteTarget<Ipv6>) -> fnet_routes::RouteTargetV6 {
        let RouteTarget { outbound_interface, next_hop } = target;
        fnet_routes::RouteTargetV6 {
            outbound_interface: outbound_interface,
            next_hop: next_hop.map(|addr| Box::new((*addr).into_ext())),
        }
    }
}

/// The action of a route, abstracting over [`fnet_routes::RouteActionV4`] and
/// [`fnet_routes::RouteActionV6`].
///
/// These fidl types are both defined as flexible unions, which allows the
/// definition to grow over time. The `Unknown` enum variant accounts for any
/// new types that are not yet known to the local version of the FIDL bindings.
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
pub enum RouteAction<I: Ip> {
    /// The RouteAction is unknown.
    Unknown,
    /// Forward packets to the specified target.
    Forward(RouteTarget<I>),
}

#[derive(Debug, Error, PartialEq, Eq)]
#[allow(missing_docs)]
pub enum NeverMissingFields {}

impl TryFrom<fnet_routes::RouteActionV4> for RouteAction<Ipv4> {
    type Error = FidlConversionError<NeverMissingFields>;
    fn try_from(action: fnet_routes::RouteActionV4) -> Result<Self, Self::Error> {
        match action {
            fnet_routes::RouteActionV4::Forward(target) => {
                Ok(RouteAction::Forward(target.try_into()?))
            }
            fnet_routes::RouteActionV4Unknown!() => Ok(RouteAction::Unknown),
        }
    }
}

impl TryFrom<fnet_routes::RouteActionV6> for RouteAction<Ipv6> {
    type Error = FidlConversionError<NeverMissingFields>;
    fn try_from(action: fnet_routes::RouteActionV6) -> Result<Self, Self::Error> {
        match action {
            fnet_routes::RouteActionV6::Forward(target) => {
                Ok(RouteAction::Forward(target.try_into()?))
            }
            fnet_routes::RouteActionV4Unknown!() => Ok(RouteAction::Unknown),
        }
    }
}

const ROUTE_ACTION_V4_UNKNOWN_VARIANT_TAG: &str = "fuchsia.net.routes/RouteActionV4";

impl TryFrom<RouteAction<Ipv4>> for fnet_routes::RouteActionV4 {
    type Error = NetTypeConversionError;
    fn try_from(action: RouteAction<Ipv4>) -> Result<Self, Self::Error> {
        match action {
            RouteAction::Forward(target) => Ok(fnet_routes::RouteActionV4::Forward(target.into())),
            RouteAction::Unknown => Err(NetTypeConversionError::UnknownUnionVariant(
                ROUTE_ACTION_V4_UNKNOWN_VARIANT_TAG,
            )),
        }
    }
}

const ROUTE_ACTION_V6_UNKNOWN_VARIANT_TAG: &str = "fuchsia.net.routes/RouteActionV6";

impl TryFrom<RouteAction<Ipv6>> for fnet_routes::RouteActionV6 {
    type Error = NetTypeConversionError;
    fn try_from(action: RouteAction<Ipv6>) -> Result<Self, Self::Error> {
        match action {
            RouteAction::Forward(target) => Ok(fnet_routes::RouteActionV6::Forward(target.into())),
            RouteAction::Unknown => Err(NetTypeConversionError::UnknownUnionVariant(
                ROUTE_ACTION_V6_UNKNOWN_VARIANT_TAG,
            )),
        }
    }
}

/// A route, abstracting over [`fnet_routes::RouteV4`] and
/// [`fnet_routes::RouteV6`].
///
/// The `destination` subnet is verified to be a valid subnet; e.g. its
/// prefix-len is a valid value, and its host bits are cleared.
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
pub struct Route<I: Ip> {
    /// The destination subnet of the route.
    pub destination: Subnet<I::Addr>,
    /// The action specifying how to handle packets matching this route.
    pub action: RouteAction<I>,
    /// The additional properties of the route.
    pub properties: RouteProperties,
}

impl<I: Ip> Route<I> {
    /// Constructs a new route with metric `metric` that forwards any packets to `destination` over
    /// `outbound_interface`.
    pub fn new_forward(
        destination: Subnet<I::Addr>,
        outbound_interface: u64,
        next_hop: Option<SpecifiedAddr<I::Addr>>,
        metric: fnet_routes::SpecifiedMetric,
    ) -> Self {
        Self {
            destination,
            action: RouteAction::Forward(RouteTarget { outbound_interface, next_hop }),
            properties: RouteProperties {
                specified_properties: SpecifiedRouteProperties { metric },
            },
        }
    }

    /// Constructs a new route that forwards any packets to `destination` over
    /// `outbound_interface`, inheriting `outbound_interface`'s metric.
    pub fn new_forward_with_inherited_metric(
        destination: Subnet<I::Addr>,
        outbound_interface: u64,
        next_hop: Option<SpecifiedAddr<I::Addr>>,
    ) -> Self {
        Self::new_forward(
            destination,
            outbound_interface,
            next_hop,
            fnet_routes::SpecifiedMetric::InheritedFromInterface(fnet_routes::Empty),
        )
    }

    //// Constructs a new route with metric `metric` that forwards any packets to `destination` over
    /// `outbound_interface`.
    pub fn new_forward_with_explicit_metric(
        destination: Subnet<I::Addr>,
        outbound_interface: u64,
        next_hop: Option<SpecifiedAddr<I::Addr>>,
        metric: u32,
    ) -> Self {
        Self::new_forward(
            destination,
            outbound_interface,
            next_hop,
            fnet_routes::SpecifiedMetric::ExplicitMetric(metric),
        )
    }
}

impl TryFrom<fnet_routes::RouteV4> for Route<Ipv4> {
    type Error = FidlConversionError<RoutePropertiesRequiredFields>;
    fn try_from(route: fnet_routes::RouteV4) -> Result<Self, Self::Error> {
        let fnet_routes::RouteV4 { destination, action, properties } = route;
        Ok(Route {
            destination: destination
                .try_into_ext()
                .map_err(FidlConversionError::DestinationSubnet)?,
            action: action
                .try_into()
                .map_err(|e: FidlConversionError<_>| e.map_unset_fields(|never| match never {}))?,
            properties: properties.try_into()?,
        })
    }
}

impl TryFrom<fnet_routes::RouteV6> for Route<Ipv6> {
    type Error = FidlConversionError<RoutePropertiesRequiredFields>;
    fn try_from(route: fnet_routes::RouteV6) -> Result<Self, Self::Error> {
        let fnet_routes::RouteV6 { destination, action, properties } = route;
        let destination =
            destination.try_into_ext().map_err(FidlConversionError::DestinationSubnet)?;
        Ok(Route {
            destination,
            action: action
                .try_into()
                .map_err(|e: FidlConversionError<_>| e.map_unset_fields(|never| match never {}))?,
            properties: properties.try_into()?,
        })
    }
}

impl TryFrom<Route<Ipv4>> for fnet_routes::RouteV4 {
    type Error = NetTypeConversionError;
    fn try_from(route: Route<Ipv4>) -> Result<Self, Self::Error> {
        let Route { destination, action, properties } = route;
        Ok(fnet_routes::RouteV4 {
            destination: fnet::Ipv4AddressWithPrefix {
                addr: destination.network().into_ext(),
                prefix_len: destination.prefix(),
            },
            action: action.try_into()?,
            properties: properties.into(),
        })
    }
}

impl TryFrom<Route<Ipv6>> for fnet_routes::RouteV6 {
    type Error = NetTypeConversionError;
    fn try_from(route: Route<Ipv6>) -> Result<Self, Self::Error> {
        let Route { destination, action, properties } = route;
        Ok(fnet_routes::RouteV6 {
            destination: fnet::Ipv6AddressWithPrefix {
                addr: destination.network().into_ext(),
                prefix_len: destination.prefix(),
            },
            action: action.try_into()?,
            properties: properties.into(),
        })
    }
}

impl<I: Ip> TryFrom<Route<I>> for fnet_stack::ForwardingEntry {
    type Error = NetTypeConversionError;
    fn try_from(
        Route {
            destination,
            action,
            properties:
                RouteProperties { specified_properties: SpecifiedRouteProperties { metric } },
        }: Route<I>,
    ) -> Result<Self, Self::Error> {
        let RouteTarget { outbound_interface, next_hop } = match action {
            RouteAction::Unknown => {
                return Err(NetTypeConversionError::UnknownUnionVariant(match I::VERSION {
                    net_types::ip::IpVersion::V4 => ROUTE_ACTION_V4_UNKNOWN_VARIANT_TAG,
                    net_types::ip::IpVersion::V6 => ROUTE_ACTION_V6_UNKNOWN_VARIANT_TAG,
                }));
            }
            RouteAction::Forward(target) => target,
        };

        let next_hop = I::map_ip_in(
            next_hop,
            |next_hop| next_hop.map(|addr| fnet::IpAddress::Ipv4(addr.get().into_ext())),
            |next_hop| next_hop.map(|addr| fnet::IpAddress::Ipv6(addr.get().into_ext())),
        );

        Ok(fnet_stack::ForwardingEntry {
            subnet: destination.into_ext(),
            device_id: outbound_interface,
            next_hop: next_hop.map(Box::new),
            metric: match metric {
                fnet_routes::SpecifiedMetric::ExplicitMetric(metric) => metric,
                fnet_routes::SpecifiedMetric::InheritedFromInterface(fnet_routes::Empty) => 0,
            },
        })
    }
}

/// An installed route, abstracting over [`fnet_routes::InstalledRouteV4`] and
/// [`fnet_routes::InstalledRouteV6`].
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
pub struct InstalledRoute<I: Ip> {
    /// The route.
    pub route: Route<I>,
    /// The route's effective properties.
    pub effective_properties: EffectiveRouteProperties,
    /// The table which this route belongs to.
    pub table_id: TableId,
}

impl<I: Ip> InstalledRoute<I> {
    /// Tests if the [`InstalledRoute`] matches the given route and table_id.
    pub fn matches_route_and_table_id(&self, route: &Route<I>, table_id: TableId) -> bool {
        &self.route == route && self.table_id == table_id
    }
}

/// A newtype representing the ID of a route table.
#[derive(Clone, Copy, Debug, Eq, Hash, PartialEq, PartialOrd, Ord)]
pub struct TableId(u32);

impl TableId {
    /// Constructs a new table ID.
    pub const fn new(id: u32) -> Self {
        Self(id)
    }

    /// Extracts the table ID.
    pub const fn get(self) -> u32 {
        let Self(id) = self;
        id
    }
}

impl Display for TableId {
    fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
        write!(f, "{}", self.get())
    }
}

#[derive(Error, Clone, Debug, PartialEq, Eq)]
#[allow(missing_docs)]
pub enum InstalledRouteRequiredFields {
    #[error("fuchsia.net.routes/InstalledRouteV#.route")]
    Route,
    #[error("fuchsia.net.routes/InstalledRouteV#.effective_properties")]
    EffectiveProperties,
    #[error(transparent)]
    WithinRoute(#[from] RoutePropertiesRequiredFields),
    #[error(transparent)]
    WithinEffectiveProperties(#[from] EffectiveRoutePropertiesRequiredFields),
    #[error("fuchsia.net.routes/InstalledRouteV#.table_id")]
    TableId,
}

impl TryFrom<fnet_routes::InstalledRouteV4> for InstalledRoute<Ipv4> {
    type Error = FidlConversionError<InstalledRouteRequiredFields>;
    fn try_from(installed_route: fnet_routes::InstalledRouteV4) -> Result<Self, Self::Error> {
        Ok(InstalledRoute {
            route: installed_route
                .route
                .ok_or(FidlConversionError::RequiredFieldUnset(
                    InstalledRouteRequiredFields::Route,
                ))?
                .try_into()
                .map_err(|e: FidlConversionError<_>| {
                    e.map_unset_fields(InstalledRouteRequiredFields::WithinRoute)
                })?,
            effective_properties: installed_route
                .effective_properties
                .ok_or(FidlConversionError::RequiredFieldUnset(
                    InstalledRouteRequiredFields::EffectiveProperties,
                ))?
                .try_into()
                .map_err(|e: FidlConversionError<_>| {
                    e.map_unset_fields(InstalledRouteRequiredFields::WithinEffectiveProperties)
                })?,
            table_id: TableId(installed_route.table_id.ok_or(
                FidlConversionError::RequiredFieldUnset(InstalledRouteRequiredFields::TableId),
            )?),
        })
    }
}

impl TryFrom<fnet_routes::InstalledRouteV6> for InstalledRoute<Ipv6> {
    type Error = FidlConversionError<InstalledRouteRequiredFields>;
    fn try_from(installed_route: fnet_routes::InstalledRouteV6) -> Result<Self, Self::Error> {
        Ok(InstalledRoute {
            route: installed_route
                .route
                .ok_or(FidlConversionError::RequiredFieldUnset(
                    InstalledRouteRequiredFields::Route,
                ))?
                .try_into()
                .map_err(|e: FidlConversionError<_>| {
                    e.map_unset_fields(InstalledRouteRequiredFields::WithinRoute)
                })?,
            effective_properties: installed_route
                .effective_properties
                .ok_or(FidlConversionError::RequiredFieldUnset(
                    InstalledRouteRequiredFields::EffectiveProperties,
                ))?
                .try_into()
                .map_err(|e: FidlConversionError<_>| {
                    e.map_unset_fields(InstalledRouteRequiredFields::WithinEffectiveProperties)
                })?,
            table_id: TableId(installed_route.table_id.ok_or(
                FidlConversionError::RequiredFieldUnset(InstalledRouteRequiredFields::TableId),
            )?),
        })
    }
}

impl TryFrom<InstalledRoute<Ipv4>> for fnet_routes::InstalledRouteV4 {
    type Error = NetTypeConversionError;
    fn try_from(installed_route: InstalledRoute<Ipv4>) -> Result<Self, Self::Error> {
        let InstalledRoute { route, effective_properties, table_id } = installed_route;
        Ok(fnet_routes::InstalledRouteV4 {
            route: Some(route.try_into()?),
            effective_properties: Some(effective_properties.into()),
            table_id: Some(table_id.get()),
            ..Default::default()
        })
    }
}

impl TryFrom<InstalledRoute<Ipv6>> for fnet_routes::InstalledRouteV6 {
    type Error = NetTypeConversionError;
    fn try_from(installed_route: InstalledRoute<Ipv6>) -> Result<Self, Self::Error> {
        let InstalledRoute { route, effective_properties, table_id } = installed_route;
        Ok(fnet_routes::InstalledRouteV6 {
            route: Some(route.try_into()?),
            effective_properties: Some(effective_properties.into()),
            table_id: Some(table_id.get()),
            ..Default::default()
        })
    }
}

/// An event reported to the watcher, abstracting over
/// [`fnet_routes::EventV4`] and [fnet_routes::EventV6`].
///
/// These fidl types are both defined as flexible unions, which allows the
/// definition to grow over time. The `Unknown` enum variant accounts for any
/// new types that are not yet known to the local version of the FIDL bindings.
#[derive(Clone, Copy, Debug, PartialEq)]
pub enum Event<I: Ip> {
    /// An unknown event.
    Unknown,
    /// A route that existed prior to watching.
    Existing(InstalledRoute<I>),
    /// Sentinel value indicating no more `existing` events will be received.
    Idle,
    /// A route that was added while watching.
    Added(InstalledRoute<I>),
    /// A route that was removed while watching.
    Removed(InstalledRoute<I>),
}

impl TryFrom<fnet_routes::EventV4> for Event<Ipv4> {
    type Error = FidlConversionError<InstalledRouteRequiredFields>;
    fn try_from(event: fnet_routes::EventV4) -> Result<Self, Self::Error> {
        match event {
            fnet_routes::EventV4::Existing(route) => Ok(Event::Existing(route.try_into()?)),
            fnet_routes::EventV4::Idle(fnet_routes::Empty) => Ok(Event::Idle),
            fnet_routes::EventV4::Added(route) => Ok(Event::Added(route.try_into()?)),
            fnet_routes::EventV4::Removed(route) => Ok(Event::Removed(route.try_into()?)),
            fnet_routes::EventV4Unknown!() => Ok(Event::Unknown),
        }
    }
}

impl TryFrom<fnet_routes::EventV6> for Event<Ipv6> {
    type Error = FidlConversionError<InstalledRouteRequiredFields>;
    fn try_from(event: fnet_routes::EventV6) -> Result<Self, Self::Error> {
        match event {
            fnet_routes::EventV6::Existing(route) => Ok(Event::Existing(route.try_into()?)),
            fnet_routes::EventV6::Idle(fnet_routes::Empty) => Ok(Event::Idle),
            fnet_routes::EventV6::Added(route) => Ok(Event::Added(route.try_into()?)),
            fnet_routes::EventV6::Removed(route) => Ok(Event::Removed(route.try_into()?)),
            fnet_routes::EventV6Unknown!() => Ok(Event::Unknown),
        }
    }
}

impl TryFrom<Event<Ipv4>> for fnet_routes::EventV4 {
    type Error = NetTypeConversionError;
    fn try_from(event: Event<Ipv4>) -> Result<Self, Self::Error> {
        match event {
            Event::Existing(route) => Ok(fnet_routes::EventV4::Existing(route.try_into()?)),
            Event::Idle => Ok(fnet_routes::EventV4::Idle(fnet_routes::Empty)),
            Event::Added(route) => Ok(fnet_routes::EventV4::Added(route.try_into()?)),
            Event::Removed(route) => Ok(fnet_routes::EventV4::Removed(route.try_into()?)),
            Event::Unknown => {
                Err(NetTypeConversionError::UnknownUnionVariant("fuchsia_net_routes.EventV4"))
            }
        }
    }
}

impl TryFrom<Event<Ipv6>> for fnet_routes::EventV6 {
    type Error = NetTypeConversionError;
    fn try_from(event: Event<Ipv6>) -> Result<Self, Self::Error> {
        match event {
            Event::Existing(route) => Ok(fnet_routes::EventV6::Existing(route.try_into()?)),
            Event::Idle => Ok(fnet_routes::EventV6::Idle(fnet_routes::Empty)),
            Event::Added(route) => Ok(fnet_routes::EventV6::Added(route.try_into()?)),
            Event::Removed(route) => Ok(fnet_routes::EventV6::Removed(route.try_into()?)),
            Event::Unknown => {
                Err(NetTypeConversionError::UnknownUnionVariant("fuchsia_net_routes.EventV6"))
            }
        }
    }
}

/// Route watcher creation errors.
#[derive(Clone, Debug, Error)]
pub enum WatcherCreationError {
    /// Proxy creation failed.
    #[error("failed to create route watcher proxy: {0}")]
    CreateProxy(fidl::Error),
    /// Watcher acquisition failed.
    #[error("failed to get route watcher: {0}")]
    GetWatcher(fidl::Error),
}

/// Route watcher `Watch` errors.
#[derive(Clone, Debug, Error)]
pub enum WatchError {
    /// The call to `Watch` returned a FIDL error.
    #[error("the call to `Watch()` failed: {0}")]
    Fidl(fidl::Error),
    /// The event returned by `Watch` encountered a conversion error.
    #[error("failed to convert event returned by `Watch()`: {0}")]
    Conversion(FidlConversionError<InstalledRouteRequiredFields>),
    /// The server returned an empty batch of events.
    #[error("the call to `Watch()` returned an empty batch of events")]
    EmptyEventBatch,
}

/// IP Extension for the `fuchsia.net.routes` FIDL API.
pub trait FidlRouteIpExt: Ip {
    /// The "state" protocol to use for this IP version.
    type StateMarker: fidl::endpoints::DiscoverableProtocolMarker;
    /// The "watcher" protocol to use for this IP version.
    type WatcherMarker: fidl::endpoints::ProtocolMarker;
    /// The type of "event" returned by this IP version's watcher protocol.
    type WatchEvent: TryInto<Event<Self>, Error = FidlConversionError<InstalledRouteRequiredFields>>
        + TryFrom<Event<Self>, Error = NetTypeConversionError>
        + Clone
        + std::fmt::Debug
        + PartialEq
        + Unpin
        + Send;
    /// The "route" FIDL type to use for this IP version.
    type Route: TryFrom<Route<Self>, Error = NetTypeConversionError>
        + TryInto<Route<Self>, Error = FidlConversionError<RoutePropertiesRequiredFields>>
        + std::fmt::Debug;
}

impl FidlRouteIpExt for Ipv4 {
    type StateMarker = fnet_routes::StateV4Marker;
    type WatcherMarker = fnet_routes::WatcherV4Marker;
    type WatchEvent = fnet_routes::EventV4;
    type Route = fnet_routes::RouteV4;
}

impl FidlRouteIpExt for Ipv6 {
    type StateMarker = fnet_routes::StateV6Marker;
    type WatcherMarker = fnet_routes::WatcherV6Marker;
    type WatchEvent = fnet_routes::EventV6;
    type Route = fnet_routes::RouteV6;
}

/// Abstracts over AddRoute and RemoveRoute RouteSet method responders.
pub trait Responder: fidl::endpoints::Responder + Debug + Send {
    /// The payload of the response.
    type Payload;

    /// Sends a FIDL response.
    fn send(self, result: Self::Payload) -> Result<(), fidl::Error>;
}

/// A trait for responding with a slice of objects.
///
/// This is similar to [`Responder`], but it allows the sender to send a slice
/// of objects.
// These two traits can be merged into one with GATs.
pub trait SliceResponder<Payload>: fidl::endpoints::Responder + Debug + Send {
    /// Sends a FIDL response.
    fn send(self, payload: &[Payload]) -> Result<(), fidl::Error>;
}

macro_rules! impl_responder {
    ($resp:ty, &[$payload:ty] $(,)?) => {
        impl $crate::SliceResponder<$payload> for $resp {
            fn send(self, result: &[$payload]) -> Result<(), fidl::Error> {
                <$resp>::send(self, result)
            }
        }
    };
    ($resp:ty, $payload:ty $(,)?) => {
        impl $crate::Responder for $resp {
            type Payload = $payload;

            fn send(self, result: Self::Payload) -> Result<(), fidl::Error> {
                <$resp>::send(self, result)
            }
        }
    };
}
pub(crate) use impl_responder;

/// Options for getting a route watcher.
#[derive(Default, Clone)]
pub struct WatcherOptions {
    /// The route table the watcher is interested in.
    pub table_interest: Option<fnet_routes::TableInterest>,
}

impl From<WatcherOptions> for fnet_routes::WatcherOptionsV4 {
    fn from(WatcherOptions { table_interest }: WatcherOptions) -> Self {
        Self { table_interest, __source_breaking: fidl::marker::SourceBreaking }
    }
}

impl From<WatcherOptions> for fnet_routes::WatcherOptionsV6 {
    fn from(WatcherOptions { table_interest }: WatcherOptions) -> Self {
        Self { table_interest, __source_breaking: fidl::marker::SourceBreaking }
    }
}

impl From<fnet_routes::WatcherOptionsV4> for WatcherOptions {
    fn from(
        fnet_routes::WatcherOptionsV4 { table_interest, __source_breaking: _ }: fnet_routes::WatcherOptionsV4,
    ) -> Self {
        Self { table_interest }
    }
}

impl From<fnet_routes::WatcherOptionsV6> for WatcherOptions {
    fn from(
        fnet_routes::WatcherOptionsV6 { table_interest, __source_breaking: _ }: fnet_routes::WatcherOptionsV6,
    ) -> Self {
        Self { table_interest }
    }
}

/// Dispatches either `GetWatcherV4` or `GetWatcherV6` on the state proxy.
pub fn get_watcher<I: FidlRouteIpExt>(
    state_proxy: &<I::StateMarker as fidl::endpoints::ProtocolMarker>::Proxy,
    options: WatcherOptions,
) -> Result<<I::WatcherMarker as fidl::endpoints::ProtocolMarker>::Proxy, WatcherCreationError> {
    let (watcher_proxy, watcher_server_end) = fidl::endpoints::create_proxy::<I::WatcherMarker>();

    #[derive(GenericOverIp)]
    #[generic_over_ip(I, Ip)]
    struct GetWatcherInputs<'a, I: FidlRouteIpExt> {
        watcher_server_end: fidl::endpoints::ServerEnd<I::WatcherMarker>,
        state_proxy: &'a <I::StateMarker as fidl::endpoints::ProtocolMarker>::Proxy,
        options: WatcherOptions,
    }
    let result = I::map_ip_in(
        GetWatcherInputs::<'_, I> { watcher_server_end, state_proxy, options },
        |GetWatcherInputs { watcher_server_end, state_proxy, options }| {
            state_proxy.get_watcher_v4(watcher_server_end, &options.into())
        },
        |GetWatcherInputs { watcher_server_end, state_proxy, options }| {
            state_proxy.get_watcher_v6(watcher_server_end, &options.into())
        },
    );

    result.map_err(WatcherCreationError::GetWatcher)?;
    Ok(watcher_proxy)
}

/// Calls `Watch()` on the provided `WatcherV4` or `WatcherV6` proxy.
pub fn watch<'a, I: FidlRouteIpExt>(
    watcher_proxy: &'a <I::WatcherMarker as fidl::endpoints::ProtocolMarker>::Proxy,
) -> impl Future<Output = Result<Vec<I::WatchEvent>, fidl::Error>> {
    #[derive(GenericOverIp)]
    #[generic_over_ip(I, Ip)]
    struct WatchInputs<'a, I: FidlRouteIpExt> {
        watcher_proxy: &'a <I::WatcherMarker as fidl::endpoints::ProtocolMarker>::Proxy,
    }
    #[derive(GenericOverIp)]
    #[generic_over_ip(I, Ip)]
    struct WatchOutputs<I: FidlRouteIpExt> {
        watch_fut: fidl::client::QueryResponseFut<Vec<I::WatchEvent>>,
    }
    let WatchOutputs { watch_fut } = I::map_ip::<WatchInputs<'_, I>, WatchOutputs<I>>(
        WatchInputs { watcher_proxy },
        |WatchInputs { watcher_proxy }| WatchOutputs { watch_fut: watcher_proxy.watch() },
        |WatchInputs { watcher_proxy }| WatchOutputs { watch_fut: watcher_proxy.watch() },
    );
    watch_fut
}

/// [`event_stream_from_state_with_options`] with default [`WatcherOptions`].
pub fn event_stream_from_state<I: FidlRouteIpExt>(
    routes_state: &<I::StateMarker as fidl::endpoints::ProtocolMarker>::Proxy,
) -> Result<impl Stream<Item = Result<Event<I>, WatchError>> + use<I>, WatcherCreationError> {
    event_stream_from_state_with_options(routes_state, Default::default())
}

/// Connects to the watcher protocol with [`WatcherOptions`] and converts the
/// Hanging-Get style API into an Event stream.
///
/// Each call to `Watch` returns a batch of events, which are flattened into a
/// single stream. If an error is encountered while calling `Watch` or while
/// converting the event, the stream is immediately terminated.
pub fn event_stream_from_state_with_options<I: FidlRouteIpExt>(
    routes_state: &<I::StateMarker as fidl::endpoints::ProtocolMarker>::Proxy,
    options: WatcherOptions,
) -> Result<impl Stream<Item = Result<Event<I>, WatchError>> + use<I>, WatcherCreationError> {
    let watcher = get_watcher::<I>(routes_state, options)?;
    event_stream_from_watcher(watcher)
}

/// Turns the provided watcher client into a [`Event`] stream by applying
/// Hanging-Get watch.
///
/// Each call to `Watch` returns a batch of events, which are flattened into a
/// single stream. If an error is encountered while calling `Watch` or while
/// converting the event, the stream is immediately terminated.
pub fn event_stream_from_watcher<I: FidlRouteIpExt>(
    watcher: <I::WatcherMarker as fidl::endpoints::ProtocolMarker>::Proxy,
) -> Result<impl Stream<Item = Result<Event<I>, WatchError>> + use<I>, WatcherCreationError> {
    Ok(stream::ShortCircuit::new(
        futures::stream::try_unfold(watcher, |watcher| async {
            let events_batch = watch::<I>(&watcher).await.map_err(WatchError::Fidl)?;
            if events_batch.is_empty() {
                return Err(WatchError::EmptyEventBatch);
            }
            let events_batch = events_batch
                .into_iter()
                .map(|event| event.try_into().map_err(WatchError::Conversion));
            let event_stream = futures::stream::iter(events_batch);
            Ok(Some((event_stream, watcher)))
        })
        // Flatten the stream of event streams into a single event stream.
        .try_flatten(),
    ))
}

/// Errors returned by [`collect_routes_until_idle`].
#[derive(Clone, Debug, Error)]
pub enum CollectRoutesUntilIdleError<I: FidlRouteIpExt> {
    /// There was an error in the event stream.
    #[error("there was an error in the event stream: {0}")]
    ErrorInStream(WatchError),
    /// There was an unexpected event in the event stream. Only `existing` or
    /// `idle` events are expected.
    #[error("there was an unexpected event in the event stream: {0:?}")]
    UnexpectedEvent(Event<I>),
    /// The event stream unexpectedly ended.
    #[error("the event stream unexpectedly ended")]
    StreamEnded,
}

/// Collects all `existing` events from the stream, stopping once the `idle`
/// event is observed.
pub async fn collect_routes_until_idle<
    I: FidlRouteIpExt,
    C: Extend<InstalledRoute<I>> + Default,
>(
    event_stream: impl futures::Stream<Item = Result<Event<I>, WatchError>> + Unpin,
) -> Result<C, CollectRoutesUntilIdleError<I>> {
    fold::fold_while(
        event_stream,
        Ok(C::default()),
        |existing_routes: Result<C, CollectRoutesUntilIdleError<I>>, event| {
            futures::future::ready(match existing_routes {
                Err(_) => {
                    unreachable!("`existing_routes` must be `Ok`, because we stop folding on err")
                }
                Ok(mut existing_routes) => match event {
                    Err(e) => {
                        fold::FoldWhile::Done(Err(CollectRoutesUntilIdleError::ErrorInStream(e)))
                    }
                    Ok(e) => match e {
                        Event::Existing(e) => {
                            existing_routes.extend([e]);
                            fold::FoldWhile::Continue(Ok(existing_routes))
                        }
                        Event::Idle => fold::FoldWhile::Done(Ok(existing_routes)),
                        e @ Event::Unknown | e @ Event::Added(_) | e @ Event::Removed(_) => {
                            fold::FoldWhile::Done(Err(
                                CollectRoutesUntilIdleError::UnexpectedEvent(e),
                            ))
                        }
                    },
                },
            })
        },
    )
    .await
    .short_circuited()
    .map_err(|_accumulated_thus_far: Result<C, CollectRoutesUntilIdleError<I>>| {
        CollectRoutesUntilIdleError::StreamEnded
    })?
}

/// Errors returned by [`wait_for_routes`].
#[derive(Clone, Debug, Error)]
pub enum WaitForRoutesError<I: FidlRouteIpExt> {
    /// There was an error in the event stream.
    #[error("there was an error in the event stream: {0}")]
    ErrorInStream(WatchError),
    /// There was an `Added` event for an already existing route.
    #[error("observed an added event for an already existing route: {0:?}")]
    AddedAlreadyExisting(InstalledRoute<I>),
    /// There was a `Removed` event for a non-existent route.
    #[error("observed a removed event for a non-existent route: {0:?}")]
    RemovedNonExistent(InstalledRoute<I>),
    /// There was an `Unknown` event in the stream.
    #[error("observed an unknown event")]
    UnknownEvent,
    /// The event stream unexpectedly ended.
    #[error("the event stream unexpectedly ended")]
    StreamEnded,
}

/// Wait for a condition on routing state to be satisfied, yielding a result
/// from the predicate.
///
/// With the given `initial_state`, take events from `event_stream` and update
/// the state, calling `predicate` whenever the state changes. When `predicate`
/// returns `Some(T)` yield `Ok(T)`. Note, this function will hang if no events
/// arrive on `event_stream`.
pub async fn wait_for_routes_map<
    I: FidlRouteIpExt,
    S: futures::Stream<Item = Result<Event<I>, WatchError>> + Unpin,
    T,
    F: Fn(&HashSet<InstalledRoute<I>>) -> Option<T>,
>(
    event_stream: S,
    initial_state: &mut HashSet<InstalledRoute<I>>,
    predicate: F,
) -> Result<T, WaitForRoutesError<I>> {
    fold::try_fold_while(
        event_stream.map_err(WaitForRoutesError::ErrorInStream),
        initial_state,
        |accumulated_routes, event| {
            futures::future::ready({
                match event {
                    Event::Existing(route) | Event::Added(route) => accumulated_routes
                        .insert(route)
                        .then_some(())
                        .ok_or(WaitForRoutesError::AddedAlreadyExisting(route)),
                    Event::Removed(route) => accumulated_routes
                        .remove(&route)
                        .then_some(())
                        .ok_or(WaitForRoutesError::RemovedNonExistent(route)),
                    Event::Idle => Ok(()),
                    Event::Unknown => Err(WaitForRoutesError::UnknownEvent),
                }
                .map(|()| match predicate(&accumulated_routes) {
                    Some(t) => fold::FoldWhile::Done(t),
                    None => fold::FoldWhile::Continue(accumulated_routes),
                })
            })
        },
    )
    .await?
    .short_circuited()
    .map_err(|_accumulated_thus_far: &mut HashSet<InstalledRoute<I>>| {
        WaitForRoutesError::StreamEnded
    })
}

/// Wait for a condition on routing state to be satisfied.
///
/// With the given `initial_state`, take events from `event_stream` and update
/// the state, calling `predicate` whenever the state changes. When predicates
/// returns `True` yield `Ok(())`.
pub async fn wait_for_routes<
    I: FidlRouteIpExt,
    S: futures::Stream<Item = Result<Event<I>, WatchError>> + Unpin,
    F: Fn(&HashSet<InstalledRoute<I>>) -> bool,
>(
    event_stream: S,
    initial_state: &mut HashSet<InstalledRoute<I>>,
    predicate: F,
) -> Result<(), WaitForRoutesError<I>> {
    wait_for_routes_map::<I, S, (), _>(event_stream, initial_state, |routes| {
        predicate(routes).then_some(())
    })
    .await
}

/// Resolve options for resolving route.
#[derive(Debug, Default, Clone)]
pub struct ResolveOptions {
    /// The marks used for the route resolution.
    pub marks: fnet_ext::Marks,
}

impl From<fnet_routes::ResolveOptions> for ResolveOptions {
    fn from(value: fnet_routes::ResolveOptions) -> Self {
        let fnet_routes::ResolveOptions { marks, __source_breaking } = value;
        Self { marks: marks.map(fnet_ext::Marks::from).unwrap_or_default() }
    }
}

impl From<ResolveOptions> for fnet_routes::ResolveOptions {
    fn from(value: ResolveOptions) -> Self {
        let ResolveOptions { marks } = value;
        Self { marks: Some(marks.into()), __source_breaking: fidl::marker::SourceBreaking }
    }
}

#[cfg(test)]
mod tests {
    use super::*;
    use crate::testutil::internal as internal_testutil;
    use assert_matches::assert_matches;
    use fidl_fuchsia_net as _;
    use futures::{FutureExt as _, StreamExt as _};
    use ip_test_macro::ip_test;
    use net_declare::{
        fidl_ip_v4, fidl_ip_v4_with_prefix, fidl_ip_v6, fidl_ip_v6_with_prefix, net_ip_v4,
        net_ip_v6, net_subnet_v4, net_subnet_v6,
    };
    use test_case::test_case;
    use zx_status;

    const ARBITRARY_TABLE_ID: TableId = TableId::new(0);

    /// Allows types to provided an arbitrary but valid value for tests.
    trait ArbitraryTestValue {
        fn arbitrary_test_value() -> Self;
    }

    impl ArbitraryTestValue for fnet_routes::SpecifiedRouteProperties {
        fn arbitrary_test_value() -> Self {
            fnet_routes::SpecifiedRouteProperties {
                metric: Some(fnet_routes::SpecifiedMetric::ExplicitMetric(0)),
                ..Default::default()
            }
        }
    }

    impl ArbitraryTestValue for fnet_routes::EffectiveRouteProperties {
        fn arbitrary_test_value() -> Self {
            fnet_routes::EffectiveRouteProperties { metric: Some(0), ..Default::default() }
        }
    }

    impl ArbitraryTestValue for fnet_routes::RoutePropertiesV4 {
        fn arbitrary_test_value() -> Self {
            fnet_routes::RoutePropertiesV4 {
                specified_properties: Some(
                    fnet_routes::SpecifiedRouteProperties::arbitrary_test_value(),
                ),
                ..Default::default()
            }
        }
    }

    impl ArbitraryTestValue for fnet_routes::RoutePropertiesV6 {
        fn arbitrary_test_value() -> Self {
            fnet_routes::RoutePropertiesV6 {
                specified_properties: Some(
                    fnet_routes::SpecifiedRouteProperties::arbitrary_test_value(),
                ),
                ..Default::default()
            }
        }
    }

    impl ArbitraryTestValue for fnet_routes::RouteTargetV4 {
        fn arbitrary_test_value() -> Self {
            fnet_routes::RouteTargetV4 { outbound_interface: 1, next_hop: None }
        }
    }

    impl ArbitraryTestValue for fnet_routes::RouteTargetV6 {
        fn arbitrary_test_value() -> Self {
            fnet_routes::RouteTargetV6 { outbound_interface: 1, next_hop: None }
        }
    }

    impl ArbitraryTestValue for fnet_routes::RouteActionV4 {
        fn arbitrary_test_value() -> Self {
            fnet_routes::RouteActionV4::Forward(fnet_routes::RouteTargetV4::arbitrary_test_value())
        }
    }

    impl ArbitraryTestValue for fnet_routes::RouteActionV6 {
        fn arbitrary_test_value() -> Self {
            fnet_routes::RouteActionV6::Forward(fnet_routes::RouteTargetV6::arbitrary_test_value())
        }
    }

    impl ArbitraryTestValue for fnet_routes::RouteV4 {
        fn arbitrary_test_value() -> Self {
            fnet_routes::RouteV4 {
                destination: fidl_ip_v4_with_prefix!("192.168.0.0/24"),
                action: fnet_routes::RouteActionV4::arbitrary_test_value(),
                properties: fnet_routes::RoutePropertiesV4::arbitrary_test_value(),
            }
        }
    }

    impl ArbitraryTestValue for fnet_routes::RouteV6 {
        fn arbitrary_test_value() -> Self {
            fnet_routes::RouteV6 {
                destination: fidl_ip_v6_with_prefix!("fe80::0/64"),
                action: fnet_routes::RouteActionV6::arbitrary_test_value(),
                properties: fnet_routes::RoutePropertiesV6::arbitrary_test_value(),
            }
        }
    }

    impl ArbitraryTestValue for fnet_routes::InstalledRouteV4 {
        fn arbitrary_test_value() -> Self {
            fnet_routes::InstalledRouteV4 {
                route: Some(fnet_routes::RouteV4::arbitrary_test_value()),
                effective_properties: Some(
                    fnet_routes::EffectiveRouteProperties::arbitrary_test_value(),
                ),
                table_id: Some(ARBITRARY_TABLE_ID.get()),
                ..Default::default()
            }
        }
    }

    impl ArbitraryTestValue for fnet_routes::InstalledRouteV6 {
        fn arbitrary_test_value() -> Self {
            fnet_routes::InstalledRouteV6 {
                route: Some(fnet_routes::RouteV6::arbitrary_test_value()),
                effective_properties: Some(
                    fnet_routes::EffectiveRouteProperties::arbitrary_test_value(),
                ),
                table_id: Some(ARBITRARY_TABLE_ID.get()),
                ..Default::default()
            }
        }
    }

    #[test]
    fn specified_route_properties_try_from_unset_metric() {
        assert_eq!(
            SpecifiedRouteProperties::try_from(fnet_routes::SpecifiedRouteProperties::default()),
            Err(FidlConversionError::RequiredFieldUnset(
                SpecifiedRoutePropertiesRequiredFields::Metric
            ))
        )
    }

    #[test]
    fn specified_route_properties_try_from() {
        let fidl_type = fnet_routes::SpecifiedRouteProperties {
            metric: Some(fnet_routes::SpecifiedMetric::ExplicitMetric(1)),
            ..Default::default()
        };
        let local_type =
            SpecifiedRouteProperties { metric: fnet_routes::SpecifiedMetric::ExplicitMetric(1) };
        assert_eq!(fidl_type.clone().try_into(), Ok(local_type));
        assert_eq!(
            <SpecifiedRouteProperties as std::convert::Into<
                fnet_routes::SpecifiedRouteProperties,
            >>::into(local_type),
            fidl_type.clone()
        );
    }

    #[test]
    fn effective_route_properties_try_from_unset_metric() {
        assert_eq!(
            EffectiveRouteProperties::try_from(fnet_routes::EffectiveRouteProperties::default()),
            Err(FidlConversionError::RequiredFieldUnset(
                EffectiveRoutePropertiesRequiredFields::Metric
            ))
        )
    }

    #[test]
    fn effective_route_properties_try_from() {
        let fidl_type =
            fnet_routes::EffectiveRouteProperties { metric: Some(1), ..Default::default() };
        let local_type = EffectiveRouteProperties { metric: 1 };
        assert_eq!(fidl_type.clone().try_into(), Ok(EffectiveRouteProperties { metric: 1 }));
        assert_eq!(
            <EffectiveRouteProperties as std::convert::Into<
                fnet_routes::EffectiveRouteProperties,
            >>::into(local_type),
            fidl_type.clone()
        );
    }

    #[test]
    fn route_properties_try_from_unset_specified_properties_v4() {
        assert_eq!(
            RouteProperties::try_from(fnet_routes::RoutePropertiesV4::default()),
            Err(FidlConversionError::RequiredFieldUnset(
                RoutePropertiesRequiredFields::SpecifiedProperties
            ))
        )
    }

    #[test]
    fn route_properties_try_from_unset_specified_properties_v6() {
        assert_eq!(
            RouteProperties::try_from(fnet_routes::RoutePropertiesV6::default()),
            Err(FidlConversionError::RequiredFieldUnset(
                RoutePropertiesRequiredFields::SpecifiedProperties
            ))
        )
    }

    #[test]
    fn route_properties_try_from_v4() {
        let fidl_type = fnet_routes::RoutePropertiesV4 {
            specified_properties: Some(
                fnet_routes::SpecifiedRouteProperties::arbitrary_test_value(),
            ),
            ..Default::default()
        };
        let local_type = RouteProperties {
            specified_properties: fnet_routes::SpecifiedRouteProperties::arbitrary_test_value()
                .try_into()
                .unwrap(),
        };
        assert_eq!(fidl_type.clone().try_into(), Ok(local_type));
        assert_eq!(
            <RouteProperties as std::convert::Into<fnet_routes::RoutePropertiesV4>>::into(
                local_type
            ),
            fidl_type.clone()
        );
    }

    #[test]
    fn route_properties_try_from_v6() {
        let fidl_type = fnet_routes::RoutePropertiesV6 {
            specified_properties: Some(
                fnet_routes::SpecifiedRouteProperties::arbitrary_test_value(),
            ),
            ..Default::default()
        };
        let local_type = RouteProperties {
            specified_properties: fnet_routes::SpecifiedRouteProperties::arbitrary_test_value()
                .try_into()
                .unwrap(),
        };
        assert_eq!(fidl_type.clone().try_into(), Ok(local_type));
        assert_eq!(
            <RouteProperties as std::convert::Into<fnet_routes::RoutePropertiesV6>>::into(
                local_type
            ),
            fidl_type.clone()
        );
    }

    #[test]
    fn route_target_try_from_unspecified_next_hop_v4() {
        assert_eq!(
            RouteTarget::try_from(fnet_routes::RouteTargetV4 {
                outbound_interface: 1,
                next_hop: Some(Box::new(fidl_ip_v4!("0.0.0.0"))),
            }),
            Err(FidlConversionError::UnspecifiedNextHop)
        )
    }

    #[test]
    fn route_target_try_from_unspecified_next_hop_v6() {
        assert_eq!(
            RouteTarget::try_from(fnet_routes::RouteTargetV6 {
                outbound_interface: 1,
                next_hop: Some(Box::new(fidl_ip_v6!("::"))),
            }),
            Err(FidlConversionError::UnspecifiedNextHop)
        );
    }

    #[test]
    fn route_target_try_from_limited_broadcast_next_hop_v4() {
        assert_eq!(
            RouteTarget::try_from(fnet_routes::RouteTargetV4 {
                outbound_interface: 1,
                next_hop: Some(Box::new(fidl_ip_v4!("255.255.255.255"))),
            }),
            Err(FidlConversionError::NextHopNotUnicast)
        )
    }

    #[test]
    fn route_target_try_from_multicast_next_hop_v6() {
        assert_eq!(
            RouteTarget::try_from(fnet_routes::RouteTargetV6 {
                outbound_interface: 1,
                next_hop: Some(Box::new(fidl_ip_v6!("ff00::1"))),
            }),
            Err(FidlConversionError::NextHopNotUnicast)
        )
    }

    #[test]
    fn route_target_try_from_v4() {
        let fidl_type = fnet_routes::RouteTargetV4 {
            outbound_interface: 1,
            next_hop: Some(Box::new(fidl_ip_v4!("192.168.0.1"))),
        };
        let local_type = RouteTarget {
            outbound_interface: 1,
            next_hop: Some(SpecifiedAddr::new(net_ip_v4!("192.168.0.1")).unwrap()),
        };
        assert_eq!(fidl_type.clone().try_into(), Ok(local_type));
        assert_eq!(
            <RouteTarget<Ipv4> as std::convert::Into<fnet_routes::RouteTargetV4>>::into(local_type),
            fidl_type
        );
    }

    #[test]
    fn route_target_try_from_v6() {
        let fidl_type = fnet_routes::RouteTargetV6 {
            outbound_interface: 1,
            next_hop: Some(Box::new(fidl_ip_v6!("fe80::1"))),
        };
        let local_type = RouteTarget {
            outbound_interface: 1,
            next_hop: Some(SpecifiedAddr::new(net_ip_v6!("fe80::1")).unwrap()),
        };
        assert_eq!(fidl_type.clone().try_into(), Ok(local_type));
        assert_eq!(
            <RouteTarget<Ipv6> as std::convert::Into<fnet_routes::RouteTargetV6>>::into(local_type),
            fidl_type
        );
    }

    #[test]
    fn route_action_try_from_forward_v4() {
        let fidl_type =
            fnet_routes::RouteActionV4::Forward(fnet_routes::RouteTargetV4::arbitrary_test_value());
        let local_type = RouteAction::Forward(
            fnet_routes::RouteTargetV4::arbitrary_test_value().try_into().unwrap(),
        );
        assert_eq!(fidl_type.clone().try_into(), Ok(local_type));
        assert_eq!(local_type.try_into(), Ok(fidl_type.clone()));
    }

    #[test]
    fn route_action_try_from_forward_v6() {
        let fidl_type =
            fnet_routes::RouteActionV6::Forward(fnet_routes::RouteTargetV6::arbitrary_test_value());
        let local_type = RouteAction::Forward(
            fnet_routes::RouteTargetV6::arbitrary_test_value().try_into().unwrap(),
        );
        assert_eq!(fidl_type.clone().try_into(), Ok(local_type));
        assert_eq!(local_type.try_into(), Ok(fidl_type.clone()));
    }

    #[test]
    fn route_action_try_from_unknown_v4() {
        let fidl_type = fnet_routes::RouteActionV4::unknown_variant_for_testing();
        const LOCAL_TYPE: RouteAction<Ipv4> = RouteAction::Unknown;
        assert_eq!(fidl_type.try_into(), Ok(LOCAL_TYPE));
        assert_eq!(
            LOCAL_TYPE.try_into(),
            Err::<fnet_routes::RouteActionV4, _>(NetTypeConversionError::UnknownUnionVariant(
                "fuchsia.net.routes/RouteActionV4"
            ))
        );
    }

    #[test]
    fn route_action_try_from_unknown_v6() {
        let fidl_type = fnet_routes::RouteActionV6::unknown_variant_for_testing();
        const LOCAL_TYPE: RouteAction<Ipv6> = RouteAction::Unknown;
        assert_eq!(fidl_type.try_into(), Ok(LOCAL_TYPE));
        assert_eq!(
            LOCAL_TYPE.try_into(),
            Err::<fnet_routes::RouteActionV6, _>(NetTypeConversionError::UnknownUnionVariant(
                "fuchsia.net.routes/RouteActionV6"
            ))
        );
    }

    #[test]
    fn route_try_from_invalid_destination_v4() {
        assert_matches!(
            Route::try_from(fnet_routes::RouteV4 {
                // Invalid, because subnets should not have the "host bits" set.
                destination: fidl_ip_v4_with_prefix!("192.168.0.1/24"),
                action: fnet_routes::RouteActionV4::arbitrary_test_value(),
                properties: fnet_routes::RoutePropertiesV4::arbitrary_test_value(),
            }),
            Err(FidlConversionError::DestinationSubnet(_))
        );
    }

    #[test]
    fn route_try_from_invalid_destination_v6() {
        assert_matches!(
            Route::try_from(fnet_routes::RouteV6 {
                // Invalid, because subnets should not have the "host bits" set.
                destination: fidl_ip_v6_with_prefix!("fe80::1/64"),
                action: fnet_routes::RouteActionV6::arbitrary_test_value(),
                properties: fnet_routes::RoutePropertiesV6::arbitrary_test_value(),
            }),
            Err(FidlConversionError::DestinationSubnet(_))
        );
    }

    #[test]
    fn route_try_from_v4() {
        let fidl_type = fnet_routes::RouteV4 {
            destination: fidl_ip_v4_with_prefix!("192.168.0.0/24"),
            action: fnet_routes::RouteActionV4::arbitrary_test_value(),
            properties: fnet_routes::RoutePropertiesV4::arbitrary_test_value(),
        };
        let local_type = Route {
            destination: net_subnet_v4!("192.168.0.0/24"),
            action: fnet_routes::RouteActionV4::arbitrary_test_value().try_into().unwrap(),
            properties: fnet_routes::RoutePropertiesV4::arbitrary_test_value().try_into().unwrap(),
        };
        assert_eq!(fidl_type.clone().try_into(), Ok(local_type));
        assert_eq!(local_type.try_into(), Ok(fidl_type.clone()));
    }

    #[test]
    fn route_try_from_v6() {
        let fidl_type = fnet_routes::RouteV6 {
            destination: fidl_ip_v6_with_prefix!("fe80::0/64"),
            action: fnet_routes::RouteActionV6::arbitrary_test_value(),
            properties: fnet_routes::RoutePropertiesV6::arbitrary_test_value(),
        };
        let local_type = Route {
            destination: net_subnet_v6!("fe80::0/64"),
            action: fnet_routes::RouteActionV6::arbitrary_test_value().try_into().unwrap(),
            properties: fnet_routes::RoutePropertiesV6::arbitrary_test_value().try_into().unwrap(),
        };
        assert_eq!(fidl_type.clone().try_into(), Ok(local_type));
        assert_eq!(local_type.try_into(), Ok(fidl_type.clone()));
    }

    #[test]
    fn installed_route_try_from_unset_route_v4() {
        assert_eq!(
            InstalledRoute::try_from(fnet_routes::InstalledRouteV4 {
                route: None,
                effective_properties: Some(
                    fnet_routes::EffectiveRouteProperties::arbitrary_test_value(),
                ),
                table_id: Some(ARBITRARY_TABLE_ID.get()),
                ..Default::default()
            }),
            Err(FidlConversionError::RequiredFieldUnset(InstalledRouteRequiredFields::Route))
        )
    }

    #[test]
    fn installed_route_try_from_unset_route_v6() {
        assert_eq!(
            InstalledRoute::try_from(fnet_routes::InstalledRouteV6 {
                route: None,
                effective_properties: Some(
                    fnet_routes::EffectiveRouteProperties::arbitrary_test_value(),
                ),
                table_id: Some(ARBITRARY_TABLE_ID.get()),
                ..Default::default()
            }),
            Err(FidlConversionError::RequiredFieldUnset(InstalledRouteRequiredFields::Route))
        )
    }

    #[test]
    fn installed_route_try_from_unset_effective_properties_v4() {
        assert_eq!(
            InstalledRoute::try_from(fnet_routes::InstalledRouteV4 {
                route: Some(fnet_routes::RouteV4::arbitrary_test_value()),
                effective_properties: None,
                table_id: Some(ARBITRARY_TABLE_ID.get()),
                ..Default::default()
            }),
            Err(FidlConversionError::RequiredFieldUnset(
                InstalledRouteRequiredFields::EffectiveProperties
            ))
        )
    }

    #[test]
    fn installed_route_try_from_unset_effective_properties_v6() {
        assert_eq!(
            InstalledRoute::try_from(fnet_routes::InstalledRouteV6 {
                route: Some(fnet_routes::RouteV6::arbitrary_test_value()),
                effective_properties: None,
                table_id: Some(ARBITRARY_TABLE_ID.get()),
                ..Default::default()
            }),
            Err(FidlConversionError::RequiredFieldUnset(
                InstalledRouteRequiredFields::EffectiveProperties
            ))
        )
    }

    #[test]
    fn installed_route_try_from_v4() {
        let fidl_type = fnet_routes::InstalledRouteV4 {
            route: Some(fnet_routes::RouteV4::arbitrary_test_value()),
            effective_properties: Some(
                fnet_routes::EffectiveRouteProperties::arbitrary_test_value(),
            ),
            table_id: Some(ARBITRARY_TABLE_ID.get()),
            ..Default::default()
        };
        let local_type = InstalledRoute {
            route: fnet_routes::RouteV4::arbitrary_test_value().try_into().unwrap(),
            effective_properties: fnet_routes::EffectiveRouteProperties::arbitrary_test_value()
                .try_into()
                .unwrap(),
            table_id: ARBITRARY_TABLE_ID,
        };
        assert_eq!(fidl_type.clone().try_into(), Ok(local_type));
        assert_eq!(local_type.try_into(), Ok(fidl_type.clone()));
    }

    #[test]
    fn installed_route_try_from_v6() {
        let fidl_type = fnet_routes::InstalledRouteV6 {
            route: Some(fnet_routes::RouteV6::arbitrary_test_value()),
            effective_properties: Some(
                fnet_routes::EffectiveRouteProperties::arbitrary_test_value(),
            ),
            table_id: Some(ARBITRARY_TABLE_ID.get()),
            ..Default::default()
        };
        let local_type = InstalledRoute {
            route: fnet_routes::RouteV6::arbitrary_test_value().try_into().unwrap(),
            effective_properties: fnet_routes::EffectiveRouteProperties::arbitrary_test_value()
                .try_into()
                .unwrap(),
            table_id: ARBITRARY_TABLE_ID,
        };
        assert_eq!(fidl_type.clone().try_into(), Ok(local_type));
        assert_eq!(local_type.try_into(), Ok(fidl_type.clone()));
    }

    #[test]
    fn event_try_from_v4() {
        let fidl_route = fnet_routes::InstalledRouteV4::arbitrary_test_value();
        let local_route = fidl_route.clone().try_into().unwrap();
        assert_eq!(
            fnet_routes::EventV4::unknown_variant_for_testing().try_into(),
            Ok(Event::Unknown)
        );
        assert_eq!(
            Event::<Ipv4>::Unknown.try_into(),
            Err::<fnet_routes::EventV4, _>(NetTypeConversionError::UnknownUnionVariant(
                "fuchsia_net_routes.EventV4"
            ))
        );
        assert_eq!(
            fnet_routes::EventV4::Existing(fidl_route.clone()).try_into(),
            Ok(Event::Existing(local_route))
        );
        assert_eq!(
            Event::Existing(local_route).try_into(),
            Ok(fnet_routes::EventV4::Existing(fidl_route.clone()))
        );

        assert_eq!(fnet_routes::EventV4::Idle(fnet_routes::Empty).try_into(), Ok(Event::Idle));
        assert_eq!(Event::Idle.try_into(), Ok(fnet_routes::EventV4::Idle(fnet_routes::Empty)));
        assert_eq!(
            fnet_routes::EventV4::Added(fidl_route.clone()).try_into(),
            Ok(Event::Added(local_route))
        );
        assert_eq!(
            Event::Added(local_route).try_into(),
            Ok(fnet_routes::EventV4::Added(fidl_route.clone()))
        );
        assert_eq!(
            fnet_routes::EventV4::Removed(fidl_route.clone()).try_into(),
            Ok(Event::Removed(local_route))
        );
        assert_eq!(
            Event::Removed(local_route).try_into(),
            Ok(fnet_routes::EventV4::Removed(fidl_route.clone()))
        );
    }

    #[test]
    fn event_try_from_v6() {
        let fidl_route = fnet_routes::InstalledRouteV6::arbitrary_test_value();
        let local_route = fidl_route.clone().try_into().unwrap();
        assert_eq!(
            fnet_routes::EventV6::unknown_variant_for_testing().try_into(),
            Ok(Event::Unknown)
        );
        assert_eq!(
            Event::<Ipv6>::Unknown.try_into(),
            Err::<fnet_routes::EventV6, _>(NetTypeConversionError::UnknownUnionVariant(
                "fuchsia_net_routes.EventV6"
            ))
        );
        assert_eq!(
            fnet_routes::EventV6::Existing(fidl_route.clone()).try_into(),
            Ok(Event::Existing(local_route))
        );
        assert_eq!(
            Event::Existing(local_route).try_into(),
            Ok(fnet_routes::EventV6::Existing(fidl_route.clone()))
        );

        assert_eq!(fnet_routes::EventV6::Idle(fnet_routes::Empty).try_into(), Ok(Event::Idle));
        assert_eq!(Event::Idle.try_into(), Ok(fnet_routes::EventV6::Idle(fnet_routes::Empty)));
        assert_eq!(
            fnet_routes::EventV6::Added(fidl_route.clone()).try_into(),
            Ok(Event::Added(local_route))
        );
        assert_eq!(
            Event::Added(local_route).try_into(),
            Ok(fnet_routes::EventV6::Added(fidl_route.clone()))
        );
        assert_eq!(
            fnet_routes::EventV6::Removed(fidl_route.clone()).try_into(),
            Ok(Event::Removed(local_route))
        );
        assert_eq!(
            Event::Removed(local_route).try_into(),
            Ok(fnet_routes::EventV6::Removed(fidl_route.clone()))
        );
    }

    // Tests the `event_stream_from_state` with various "shapes". The test
    // parameter is a vec of ranges, where each range corresponds to the batch
    // of events that will be sent in response to a single call to `Watch().
    #[ip_test(I)]
    #[test_case(Vec::new(); "no events")]
    #[test_case(vec![0..1]; "single_batch_single_event")]
    #[test_case(vec![0..10]; "single_batch_many_events")]
    #[test_case(vec![0..10, 10..20, 20..30]; "many_batches_many_events")]
    #[fuchsia_async::run_singlethreaded(test)]
    async fn event_stream_from_state_against_shape<I: FidlRouteIpExt>(
        test_shape: Vec<std::ops::Range<u32>>,
    ) {
        // Build the event stream based on the `test_shape`. Use a channel
        // so that the stream stays open until `close_channel` is called later.
        let (batches_sender, batches_receiver) =
            futures::channel::mpsc::unbounded::<Vec<I::WatchEvent>>();
        for batch_shape in &test_shape {
            batches_sender
                .unbounded_send(internal_testutil::generate_events_in_range::<I>(
                    batch_shape.clone(),
                ))
                .expect("failed to send event batch");
        }

        // Instantiate the fake Watcher implementation.
        let (state, state_server_end) = fidl::endpoints::create_proxy::<I::StateMarker>();
        let (mut state_request_stream, _control_handle) =
            state_server_end.into_stream_and_control_handle();
        let watcher_fut = state_request_stream
            .next()
            .then(|req| {
                testutil::serve_state_request::<I>(
                    req.expect("State request_stream unexpectedly ended"),
                    batches_receiver,
                )
            })
            .fuse();

        let event_stream =
            event_stream_from_state::<I>(&state).expect("failed to connect to watcher").fuse();

        futures::pin_mut!(watcher_fut, event_stream);

        for batch_shape in test_shape {
            for event_idx in batch_shape.into_iter() {
                futures::select! {
                    () = watcher_fut => panic!("fake watcher implementation unexpectedly finished"),
                    event = event_stream.next() => {
                        let actual_event = event
                            .expect("event stream unexpectedly empty")
                            .expect("error processing event");
                        let expected_event = internal_testutil::generate_event::<I>(event_idx)
                                .try_into()
                                .expect("test event is unexpectedly invalid");
                        assert_eq!(actual_event, expected_event);
                    }
                };
            }
        }

        // Close `batches_sender` and observe that the `event_stream` ends.
        batches_sender.close_channel();
        let ((), mut events) = futures::join!(watcher_fut, event_stream.collect::<Vec<_>>());
        assert_matches!(
            events.pop(),
            Some(Err(WatchError::Fidl(fidl::Error::ClientChannelClosed {
                status: zx_status::Status::PEER_CLOSED,
                ..
            })))
        );
        assert_matches!(events[..], []);
    }

    // Verify that calling `event_stream_from_state` multiple times with the
    // same `State` proxy, results in independent `Watcher` clients.
    #[ip_test(I)]
    #[fuchsia_async::run_singlethreaded]
    async fn event_stream_from_state_multiple_watchers<I: FidlRouteIpExt>() {
        // Events for 3 watchers. Each receives one batch containing 10 events.
        let test_data = vec![
            vec![internal_testutil::generate_events_in_range::<I>(0..10)],
            vec![internal_testutil::generate_events_in_range::<I>(10..20)],
            vec![internal_testutil::generate_events_in_range::<I>(20..30)],
        ];

        // Instantiate the fake Watcher implementations.
        let (state, state_server_end) = fidl::endpoints::create_proxy::<I::StateMarker>();
        let (state_request_stream, _control_handle) =
            state_server_end.into_stream_and_control_handle();
        let watchers_fut = state_request_stream
            .zip(futures::stream::iter(test_data.clone()))
            .for_each_concurrent(std::usize::MAX, |(request, watcher_data)| {
                testutil::serve_state_request::<I>(request, futures::stream::iter(watcher_data))
            });

        let validate_event_streams_fut =
            futures::future::join_all(test_data.into_iter().map(|watcher_data| {
                let events_fut = event_stream_from_state::<I>(&state)
                    .expect("failed to connect to watcher")
                    .collect::<std::collections::VecDeque<_>>();
                events_fut.then(|mut events| {
                    for expected_event in watcher_data.into_iter().flatten() {
                        assert_eq!(
                            events
                                .pop_front()
                                .expect("event_stream unexpectedly empty")
                                .expect("error processing event"),
                            expected_event.try_into().expect("test event is unexpectedly invalid"),
                        );
                    }
                    assert_matches!(
                        events.pop_front(),
                        Some(Err(WatchError::Fidl(fidl::Error::ClientChannelClosed {
                            status: zx_status::Status::PEER_CLOSED,
                            ..
                        })))
                    );
                    assert_matches!(events.make_contiguous(), []);
                    futures::future::ready(())
                })
            }));

        let ((), _): ((), Vec<()>) = futures::join!(watchers_fut, validate_event_streams_fut);
    }

    // Verify that failing to convert an event results in an error and closes
    // the event stream. `trailing_event` and `trailing_batch` control whether
    // a good event is sent after the bad event, either as part of the same
    // batch or in a subsequent batch. The test expects this data to be
    // truncated from the resulting event_stream.
    #[ip_test(I)]
    #[test_case(false, false; "no_trailing")]
    #[test_case(true, false; "trailing_event")]
    #[test_case(false, true; "trailing_batch")]
    #[test_case(true, true; "trailing_event_and_batch")]
    #[fuchsia_async::run_singlethreaded(test)]
    async fn event_stream_from_state_conversion_error<I: FidlRouteIpExt>(
        trailing_event: bool,
        trailing_batch: bool,
    ) {
        // Define an event with an invalid destination subnet; receiving it
        // from a call to `Watch` will result in conversion errors.
        #[derive(GenericOverIp)]
        #[generic_over_ip(I, Ip)]
        struct EventHolder<I: FidlRouteIpExt>(I::WatchEvent);
        let EventHolder(bad_event) = I::map_ip(
            (),
            |()| {
                EventHolder(fnet_routes::EventV4::Added(fnet_routes::InstalledRouteV4 {
                    route: Some(fnet_routes::RouteV4 {
                        destination: fidl_ip_v4_with_prefix!("192.168.0.1/24"),
                        ..fnet_routes::RouteV4::arbitrary_test_value()
                    }),
                    ..fnet_routes::InstalledRouteV4::arbitrary_test_value()
                }))
            },
            |()| {
                EventHolder(fnet_routes::EventV6::Added(fnet_routes::InstalledRouteV6 {
                    route: Some(fnet_routes::RouteV6 {
                        destination: fidl_ip_v6_with_prefix!("fe80::1/64"),
                        ..fnet_routes::RouteV6::arbitrary_test_value()
                    }),
                    ..fnet_routes::InstalledRouteV6::arbitrary_test_value()
                }))
            },
        );

        let batch = std::iter::once(bad_event)
            // Optionally append a known good event to the batch.
            .chain(trailing_event.then(|| internal_testutil::generate_event::<I>(0)).into_iter())
            .collect::<Vec<_>>();
        let batches = std::iter::once(batch)
            // Optionally append a known good batch to the sequence of batches.
            .chain(trailing_batch.then(|| vec![internal_testutil::generate_event::<I>(1)]))
            .collect::<Vec<_>>();

        // Instantiate the fake Watcher implementation.
        let (state, state_server_end) = fidl::endpoints::create_proxy::<I::StateMarker>();
        let (mut state_request_stream, _control_handle) =
            state_server_end.into_stream_and_control_handle();
        let watcher_fut = state_request_stream
            .next()
            .then(|req| {
                testutil::serve_state_request::<I>(
                    req.expect("State request_stream unexpectedly ended"),
                    futures::stream::iter(batches),
                )
            })
            .fuse();

        let event_stream =
            event_stream_from_state::<I>(&state).expect("failed to connect to watcher").fuse();

        futures::pin_mut!(watcher_fut, event_stream);
        let ((), events) = futures::join!(watcher_fut, event_stream.collect::<Vec<_>>());
        assert_matches!(&events[..], &[Err(WatchError::Conversion(_))]);
    }

    // Verify that watching an empty batch results in an error and closes
    // the event stream. When `trailing_batch` is true, an additional "good"
    // batch will be sent after the empty batch; the test expects this data to
    // be truncated from the resulting event_stream.
    #[ip_test(I)]
    #[test_case(false; "no_trailing_batch")]
    #[test_case(true; "trailing_batch")]
    #[fuchsia_async::run_singlethreaded(test)]
    async fn event_stream_from_state_empty_batch_error<I: FidlRouteIpExt>(trailing_batch: bool) {
        let batches = std::iter::once(Vec::new())
            // Optionally append a known good batch to the sequence of batches.
            .chain(trailing_batch.then(|| vec![internal_testutil::generate_event::<I>(0)]))
            .collect::<Vec<_>>();

        // Instantiate the fake Watcher implementation.
        let (state, state_server_end) = fidl::endpoints::create_proxy::<I::StateMarker>();
        let (mut state_request_stream, _control_handle) =
            state_server_end.into_stream_and_control_handle();
        let watcher_fut = state_request_stream
            .next()
            .then(|req| {
                testutil::serve_state_request::<I>(
                    req.expect("State request_stream unexpectedly ended"),
                    futures::stream::iter(batches),
                )
            })
            .fuse();

        let event_stream =
            event_stream_from_state::<I>(&state).expect("failed to connect to watcher").fuse();

        futures::pin_mut!(watcher_fut, event_stream);
        let ((), events) = futures::join!(watcher_fut, event_stream.collect::<Vec<_>>());
        assert_matches!(&events[..], &[Err(WatchError::EmptyEventBatch)]);
    }

    fn arbitrary_test_route<I: Ip + FidlRouteIpExt>() -> InstalledRoute<I> {
        #[derive(GenericOverIp)]
        #[generic_over_ip(I, Ip)]
        struct RouteHolder<I: FidlRouteIpExt>(InstalledRoute<I>);
        let RouteHolder(route) = I::map_ip(
            (),
            |()| {
                RouteHolder(
                    fnet_routes::InstalledRouteV4::arbitrary_test_value().try_into().unwrap(),
                )
            },
            |()| {
                RouteHolder(
                    fnet_routes::InstalledRouteV6::arbitrary_test_value().try_into().unwrap(),
                )
            },
        );
        route
    }

    enum CollectRoutesUntilIdleErrorTestCase {
        ErrorInStream,
        UnexpectedEvent,
        StreamEnded,
    }

    #[ip_test(I)]
    #[test_case(CollectRoutesUntilIdleErrorTestCase::ErrorInStream; "error_in_stream")]
    #[test_case(CollectRoutesUntilIdleErrorTestCase::UnexpectedEvent; "unexpected_event")]
    #[test_case(CollectRoutesUntilIdleErrorTestCase::StreamEnded; "stream_ended")]
    #[fuchsia_async::run_singlethreaded(test)]
    async fn collect_routes_until_idle_error<I: FidlRouteIpExt>(
        test_case: CollectRoutesUntilIdleErrorTestCase,
    ) {
        // Build up the test data and the expected outcome base on `test_case`.
        // Note, that `netstack_test` doesn't support test cases whose args are
        // generic functions (below, `test_assertion` is generic over `I`).
        let route = arbitrary_test_route();
        let (event, test_assertion): (_, Box<dyn FnOnce(_)>) = match test_case {
            CollectRoutesUntilIdleErrorTestCase::ErrorInStream => (
                Err(WatchError::EmptyEventBatch),
                Box::new(|result| {
                    assert_matches!(result, Err(CollectRoutesUntilIdleError::ErrorInStream(_)))
                }),
            ),
            CollectRoutesUntilIdleErrorTestCase::UnexpectedEvent => (
                Ok(Event::Added(route)),
                Box::new(|result| {
                    assert_matches!(result, Err(CollectRoutesUntilIdleError::UnexpectedEvent(_)))
                }),
            ),
            CollectRoutesUntilIdleErrorTestCase::StreamEnded => (
                Ok(Event::Existing(route)),
                Box::new(|result| {
                    assert_matches!(result, Err(CollectRoutesUntilIdleError::StreamEnded))
                }),
            ),
        };

        let event_stream = futures::stream::once(futures::future::ready(event));
        futures::pin_mut!(event_stream);
        let result = collect_routes_until_idle::<I, Vec<_>>(event_stream).await;
        test_assertion(result);
    }

    // Verifies that `collect_routes_until_idle` collects all existing events,
    // drops the idle event, and leaves all trailing events intact.
    #[ip_test(I)]
    #[fuchsia_async::run_singlethreaded]
    async fn collect_routes_until_idle_success<I: FidlRouteIpExt>() {
        let route = arbitrary_test_route();
        let event_stream = futures::stream::iter([
            Ok(Event::Existing(route)),
            Ok(Event::Idle),
            Ok(Event::Added(route)),
        ]);

        futures::pin_mut!(event_stream);
        let existing = collect_routes_until_idle::<I, Vec<_>>(event_stream.by_ref())
            .await
            .expect("failed to collect existing routes");
        assert_eq!(&existing, &[route]);

        let trailing_events = event_stream.collect::<Vec<_>>().await;
        assert_matches!(
            &trailing_events[..],
            &[Ok(Event::Added(found_route))] if found_route == route
        );
    }

    #[ip_test(I)]
    #[fuchsia_async::run_singlethreaded]
    async fn wait_for_routes_errors<I: FidlRouteIpExt>() {
        let mut state = HashSet::new();
        let event_stream =
            futures::stream::once(futures::future::ready(Err(WatchError::EmptyEventBatch)));
        assert_matches!(
            wait_for_routes::<I, _, _>(event_stream, &mut state, |_| true).await,
            Err(WaitForRoutesError::ErrorInStream(WatchError::EmptyEventBatch))
        );
        assert!(state.is_empty());

        let event_stream = futures::stream::empty();
        assert_matches!(
            wait_for_routes::<I, _, _>(event_stream, &mut state, |_| true).await,
            Err(WaitForRoutesError::StreamEnded)
        );
        assert!(state.is_empty());

        let event_stream = futures::stream::once(futures::future::ready(Ok(Event::<I>::Unknown)));
        assert_matches!(
            wait_for_routes::<I, _, _>(event_stream, &mut state, |_| true).await,
            Err(WaitForRoutesError::UnknownEvent)
        );
        assert!(state.is_empty());
    }

    #[ip_test(I)]
    #[fuchsia_async::run_singlethreaded]
    async fn wait_for_routes_add_remove<I: FidlRouteIpExt>() {
        let into_stream = |t| futures::stream::once(futures::future::ready(t));

        let route = arbitrary_test_route::<I>();
        let mut state = HashSet::new();

        // Verify that checking for the presence of a route blocks until the
        // route is added.
        let has_route = |routes: &HashSet<InstalledRoute<I>>| routes.contains(&route);
        assert_matches!(
            wait_for_routes::<I, _, _>(futures::stream::pending(), &mut state, has_route)
                .now_or_never(),
            None
        );
        assert!(state.is_empty());
        assert_matches!(
            wait_for_routes::<I, _, _>(into_stream(Ok(Event::Added(route))), &mut state, has_route)
                .now_or_never(),
            Some(Ok(()))
        );
        assert_eq!(state, HashSet::from_iter([route]));

        // Re-add the route and observe an error.
        assert_matches!(
            wait_for_routes::<I, _, _>(into_stream(Ok(Event::Added(route))), &mut state, has_route)
                .now_or_never(),
            Some(Err(WaitForRoutesError::AddedAlreadyExisting(r))) if r == route
        );
        assert_eq!(state, HashSet::from_iter([route]));

        // Verify that checking for the absence of a route blocks until the
        // route is removed.
        let does_not_have_route = |routes: &HashSet<InstalledRoute<I>>| !routes.contains(&route);
        assert_matches!(
            wait_for_routes::<I, _, _>(futures::stream::pending(), &mut state, does_not_have_route)
                .now_or_never(),
            None
        );
        assert_eq!(state, HashSet::from_iter([route]));
        assert_matches!(
            wait_for_routes::<I, _, _>(
                into_stream(Ok(Event::Removed(route))),
                &mut state,
                does_not_have_route
            )
            .now_or_never(),
            Some(Ok(()))
        );
        assert!(state.is_empty());

        // Remove a non-existent route and observe an error.
        assert_matches!(
            wait_for_routes::<I, _, _>(
                into_stream(Ok(Event::Removed(route))),
                &mut state,
                does_not_have_route
            ).now_or_never(),
            Some(Err(WaitForRoutesError::RemovedNonExistent(r))) if r == route
        );
        assert!(state.is_empty());
    }
}